msyavuz commented on code in PR #31310:
URL: https://github.com/apache/superset/pull/31310#discussion_r1891789740
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/transformProps.ts:
##########
@@ -27,9 +28,11 @@ import {
} from '@superset-ui/core';
import { getComparisonFontSize, getHeaderFontSize } from './utils';
+dayjs.extend(utc);
+
export const parseMetricValue = (metricValue: number | string | null) => {
if (typeof metricValue === 'string') {
- const dateObject = moment.utc(metricValue, moment.ISO_8601, true);
+ const dateObject = dayjs.utc(metricValue, undefined, true);
Review Comment:
.utc by default uses ISO_8601 undefined is there to just skip format
argument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
