giftig commented on PR #31447: URL: https://github.com/apache/superset/pull/31447#issuecomment-2545935209
Obviously you've added a lot of individual noqa rules here and it'll take quite a lot of work to go through them all. It'd be nice to get a rough summary of which ones you found you had to noqa a lot and we can assess what to do about them. If the same ones came up a lot it's probably better to not enforce them anywhere, i.e. disable them in ruff config, and make a follow up commit to fix them properly (I'm thinking specifically of all the E501, line length, exclusions). That way it's clear we're not enforcing a rule because more work is needed, rather than `noqa`s everywhere suggesting we want to ignore it in a lot of places. For many, especially the line length issues, ruff should be able to just fix them. I see you specifically chose not to ask it to make changes because you were afraid of breaking things, but I think the best plan is probably multiple PRs like: 1. Disable rules which have current violations initially 2. Make any low-hanging fixes and enable rules which are straightforward to fix 3. Tell ruff to fix ones which should be uncontroversial and raise a separate PR (or one PR for each rule for easier reviewing, if it's lots of violations of 2-3 rules) 4. Raise issues and/or PRs for any rules which we'd like to enforce but are trickier to fix or requires manual fixing. Decide which ones we don't want to enforce, or won't do yet. This should be much easier to review and test and we'll get a cleaner result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
