rusackas opened a new pull request, #31448: URL: https://github.com/apache/superset/pull/31448
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> The new Add Filter/Divider buttons were getting hidden when the browser window was too short. "But it's flexbox, that shouldn't happen" I said. Then I started looking at all the onion layers of styled divs with random heights and overrides. This PR cleans a bunch of junk up. There are fewer elements now, a few unnecessary overrides and styles are taken out, and things generally use more flexbox-native layouts. I could keep trimming until the cows come home, but I wanted to stop when the problem was fixed. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> Video demo with narration: https://github.com/user-attachments/assets/1ebaab79-71bc-40e5-975e-d09b77bf75e6 ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
