geido commented on code in PR #31374:
URL: https://github.com/apache/superset/pull/31374#discussion_r1882410842
##########
superset/commands/dashboard/update.py:
##########
@@ -202,3 +203,29 @@ def run(self) -> Model:
)
return configuration
+
+
+class UpdateDashboardColorsConfigCommand(UpdateDashboardCommand):
+ @transaction(
Review Comment:
You are right that this should be decorating the `run`. Just moved it. As
for disabling the rule, that's to commit the modified date back to its original
state when the `mark_updated` parameter is set to `False`. In all other cases,
it should commit normally using the `@transaction`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
