rusackas commented on code in PR #31358:
URL: https://github.com/apache/superset/pull/31358#discussion_r1878844277
##########
superset-frontend/packages/superset-ui-core/src/utils/html.tsx:
##########
@@ -84,7 +84,13 @@
}
export function removeHTMLTags(str: string): string {
- return str.replace(/<[^>]*>/g, '');
+ let previous;
+ let newstr = str;
+ do {
+ previous = newstr;
+ newstr = newstr.replace(/<[^>]*>/g, '');
Review Comment:
@dpgaspar this PR was opened by github as a fix for a CodeQL issue, and the
solution it gives is another CodeQL issue. Curious if you have a take on
whether we're better or worse off with this change :P
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
