mistercrunch commented on code in PR #31363:
URL: https://github.com/apache/superset/pull/31363#discussion_r1878800552


##########
Dockerfile:
##########
@@ -121,6 +121,8 @@ RUN --mount=type=bind,source=./docker,target=/docker \
         libecpg-dev \
         libldap2-dev \
     && touch superset/static/version_info.json \
+    && chown -R superset:superset /app \
+    && chmod -R 775 /app \

Review Comment:
   wondering if these 2 commands would be belong right before the `USER 
superset` command, and if we do so we might be able to simplify the `COPY` 
commands and other chown/chmod throughout the Dockerfile



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to