zhaoyongjie commented on code in PR #31372:
URL: https://github.com/apache/superset/pull/31372#discussion_r1878027909
##########
tests/unit_tests/utils/date_parser_tests.py:
##########
@@ -290,236 +226,49 @@ def test_datetime_eval() -> None:
expected = datetime(2018, 1, 1)
assert result == expected
- result = datetime_eval("datetime('2018-9')")
- expected = datetime(2018, 9, 1)
- assert result == expected
-
- # Parse compact arguments spelling
- result = datetime_eval("dateadd(datetime('today'),1,year,)")
- expected = datetime(2017, 11, 7)
- assert result == expected
-
- result = datetime_eval("dateadd(datetime('today'), -2, year)")
- expected = datetime(2014, 11, 7)
- assert result == expected
Review Comment:
I think you should understand what the previous logic did and then remove
the unit test again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
