villebro commented on PR #21014: URL: https://github.com/apache/superset/pull/21014#issuecomment-2529750372
> SHA254 hashes are 64 chars and MD5 are 32. Do you know if MD5 values are persisted in the DB? That would increase the scope of migration significantly. A quick look at the DB tables don't show any VARCHAR(32) columns, but a few with VARCHAR(50), which I haven't tracked to how they are filled. In Superset, it's primarily only used to calculate a deterministic short representation of a complex object, especially during caching, and for this purpose any other hashing algorithm can also be used. Again, the main concern is backwards compatibility - when you switch over from MD5 to SHA256, you will get 100 % cache misses, as the old values will be cached with MD5, but you will try to retrieve them using SHA256. Btw, it's probably also important to double check Superset's dependencies, as they may also be using MD5. Not sure if that's already been audited, but I'd almost be surprised if you don't run into some issues in the deps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
