michael-s-molina commented on code in PR #31265:
URL: https://github.com/apache/superset/pull/31265#discussion_r1868151438


##########
superset/db_engine_specs/trino.py:
##########
@@ -283,6 +286,8 @@ def _execute(
         )
         execute_thread.start()
 
+        # Wait for the thread to start before continuing
+        time.sleep(0.1)

Review Comment:
   @villebro @betodealmeida this is being added to make the thread run once but 
I think it's not guaranteed. Do you think we could change the initial condition 
`while not cursor.query_id` to avoid having 2 sleeps?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to