Vitor-Avila opened a new pull request, #31194:
URL: https://github.com/apache/superset/pull/31194

   ### SUMMARY
   The `Tab` and `Header` UI elements in the dashboard have an `AnchorLink`. 
These are currently visible in embedded mode. Embedded users are external that 
don't have access to the instance directly, so these links should not be 
visible.
   
   This PR hides `AnchorLinks` in embedded mode.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   **Before**
   
![image](https://github.com/user-attachments/assets/7bf7fa68-1b67-4693-a481-5fd59e526ebe)
   
   **After**
   
![image](https://github.com/user-attachments/assets/0848a87f-9eb0-4f58-83cf-d246326a9583)
   
   
   ### TESTING INSTRUCTIONS
   Tests added. For manual testing:
   1. Create a dashboard containing at least a header and a tab.
   2. Load this dashboard in embedded mode.
   3. Validate the `AnchorLinks` are not visible.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to