Antonio-RiveroMartnez opened a new pull request, #30848: URL: https://github.com/apache/superset/pull/30848
### SUMMARY This PR fixes the date picker for custom start date in time comparison section so users can click the `x` to delete the date and select a new one. Currently it shows `Invalid date` and the whole date picker gets NaN values. When the user clicks the `x` the control panel shows the error like we do for other fields and the chart cannot be created/updated because the button is disabled. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before https://github.com/user-attachments/assets/0f509043-32be-44be-8df4-9e5b33765f14 After Creating https://github.com/user-attachments/assets/ee05678e-32bf-4144-aefd-a99937499168 Updating https://github.com/user-attachments/assets/0779ca8f-ef35-4afc-8ae1-8db5ace3d69f ### TESTING INSTRUCTIONS Create a new Table with Time Comparison chart. Expand the Time Comparison section. Select Custom date on Time Shift. Select a date on shift start date. Click on the x next to it to remove it. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
