msyavuz commented on code in PR #30730:
URL: https://github.com/apache/superset/pull/30730#discussion_r1821033597
##########
superset-frontend/src/components/Chart/DrillBy/DrillByMenuItems.tsx:
##########
@@ -138,10 +138,9 @@ export const DrillByMenuItems = ({
useEffect(() => {
if (open) {
- ref.current?.input.focus({ preventScroll: true });
+ ref.current?.input?.focus({ preventScroll: true });
} else {
// Reset search input when menu is closed
- ref.current?.setValue('');
Review Comment:
There is no setValue method for Input after the migration so this would give
type errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
