geido opened a new pull request, #30719:
URL: https://github.com/apache/superset/pull/30719

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   PR https://github.com/apache/superset/pull/30438 introduced optimizations to 
enhance performance by reducing backend requests for cross and native filters. 
However, due to a lack of clarity around the specific use cases these 
functionalities are meant to support, and in response to reports of certain 
broken use cases (such as https://github.com/apache/superset/issues/30687), 
this PR simplifies the scoping logic to accommodate all use cases while still 
addressing the original issue of preventing requests for charts that are out of 
scope.
   
   Specifically:
   
   - When in global scope, all charts will be affected by the filter
   - When in specific scope, only the selected charts will be affected by the 
filter
   
   Fixes https://github.com/apache/superset/issues/30687
   
   ### TESTING INSTRUCTIONS
   1. Create a native or cross filter
   2. Change the scope to be global
   3. All charts will be affected by the filter
   4. Change the scope to only specific charts
   5. Only charts that were selected should be affected by the filter
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to