villebro commented on code in PR #30715:
URL: https://github.com/apache/superset/pull/30715#discussion_r1816815262
##########
superset/connectors/sqla/models.py:
##########
@@ -1980,6 +1980,12 @@ def has_extra_cache_key_calls(self, query_obj:
QueryObjectDict) -> bool:
templatable_statements.append(extras["where"])
if "having" in extras:
templatable_statements.append(extras["having"])
+ if "columns" in query_obj:
+ templatable_statements += [
+ c["sqlExpression"]
+ for c in query_obj["columns"]
+ if isinstance(c, dict) and c.get("sqlExpression")
Review Comment:
I believe we have a `TypeGuard` for this - if not let's add one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
