kusalk commented on code in PR #1565:
URL: https://github.com/apache/struts/pull/1565#discussion_r2796447922
##########
core/src/main/java/com/opensymphony/xwork2/interceptor/MethodFilterInterceptor.java:
##########
@@ -98,8 +98,8 @@ public Set<String> getIncludeMethodsSet() {
@Override
public String intercept(ActionInvocation invocation) throws Exception {
- if (applyInterceptor(invocation)) {
- return doIntercept(invocation);
+ if (applyInterceptor((org.apache.struts2.ActionInvocation)
invocation)) {
Review Comment:
It's a little tricky to follow at first, but we call into
`#applyInterceptor(struts2.ActionInvocation)` which itself calls into
`#applyInterceptor(xwork2.ActionInvocation)`. Thus an extending class can
override either of these methods and it will still have the intended overriding
effect.
Thus legacy applications which are still overriding
`#applyInterceptor(xwork2.ActionInvocation)` will continue to work with no
changes required. And applications that wish to prepare for Struts 7 can update
their override to the new method signature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
