lukaszlenart commented on code in PR #1201:
URL: https://github.com/apache/struts/pull/1201#discussion_r1957733675
##########
core/src/main/java/org/apache/struts2/ognl/SecurityMemberAccess.java:
##########
@@ -185,15 +185,15 @@ public boolean isAccessible(Map context, Object target,
Member member, String pr
return false;
}
- if (!checkDefaultPackageAccess(target, member)) {
+ if (target != null && !checkDefaultPackageAccess(target, member)) {
Review Comment:
Got it, removed!
##########
core/src/main/java/org/apache/struts2/ognl/SecurityMemberAccess.java:
##########
@@ -185,15 +185,15 @@ public boolean isAccessible(Map context, Object target,
Member member, String pr
return false;
}
- if (!checkDefaultPackageAccess(target, member)) {
+ if (target != null && !checkDefaultPackageAccess(target, member)) {
return false;
}
- if (!checkExclusionList(target, member)) {
+ if (target != null && !checkExclusionList(target, member)) {
Review Comment:
Got it, removed!
##########
core/src/main/java/org/apache/struts2/ognl/SecurityMemberAccess.java:
##########
@@ -185,15 +185,15 @@ public boolean isAccessible(Map context, Object target,
Member member, String pr
return false;
}
- if (!checkDefaultPackageAccess(target, member)) {
+ if (target != null && !checkDefaultPackageAccess(target, member)) {
return false;
}
- if (!checkExclusionList(target, member)) {
+ if (target != null && !checkExclusionList(target, member)) {
return false;
}
- if (!checkAllowlist(target, member)) {
+ if (target != null && !checkAllowlist(target, member)) {
Review Comment:
Got it, removed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]