hanahmily commented on PR #1001: URL: https://github.com/apache/skywalking-banyandb/pull/1001#issuecomment-4230409059
> > @eye-gu I will close this. Feel free to reopen it if you would like to continue. > > Okay. > > The core issue right now is that setting TopN to 0 to fetch all data can lead to OOM. As I mentioned earlier, min/max can be safely truncated, but truncating count/sum/mean will produce incorrect results. > > My thought is to implement TopN pushdown to the DataNode to reduce the data volume returned. I agree that this optimization shouldn't be included in this PR. > > If you agree, I will open a separate issue to address this OOM problem first, and then come back to this PR later. The issue you mentioned is unrelated to this PR. Why do you switch to another issue? I have left a comment on the new issue. What you're concerned about does not seem to be a problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
