currenjin opened a new pull request, #13809: URL: https://github.com/apache/skywalking/pull/13809
## What's this PR about? Adds unit tests for 3 more JDBC query DAOs that use inline SQL (no protected `buildSQL` method). These use Mockito SQL capture to verify the generated queries. With the previous rounds (#13800, #13802, #13808), DAO test coverage goes from 18/39 (46%) to 21/39 (54%). ## Tests | DAO | Approach | Tests | |-----|----------|-------| | JDBCMetricsQueryDAO | protected `buildMetricsValueSql()` + Mockito capture for `readLabeledMetricsValuesWithoutEntity()` | select with aggregation op, TABLE_COLUMN + TIME_BUCKET range + limit | | JDBCServiceLabelQueryDAO | Mockito SQL capture | TABLE_COLUMN + SERVICE_ID filter, select LABEL column | | JDBCSpanAttachedEventQueryDAO | Mockito SQL capture for both ZK and SW methods | TABLE_COLUMN + trace ID IN clause, order by start_time_second/nanos | All 8 new test cases pass locally. ## Which issue does this PR relate to? N/A - test coverage improvement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
