Copilot commented on code in PR #1057:
URL:
https://github.com/apache/skywalking-banyandb/pull/1057#discussion_r3057780188
##########
banyand/metadata/schema/checker_test.go:
##########
@@ -31,6 +33,22 @@ import (
"github.com/apache/skywalking-banyandb/pkg/test/flags"
)
+const indexRuleDir = "testdata/index_rules"
+
+var (
+ //go:embed testdata/index_rules/*.json
+ indexRuleStore embed.FS
+ //go:embed testdata/index_rule_binding.json
+ indexRuleBindingJSON string
+ //go:embed testdata/stream.json
+ streamJSON string
+)
+
+func TestSchema(t *testing.T) {
+ gomega.RegisterFailHandler(ginkgo.Fail)
+ ginkgo.RunSpecs(t, "Schema Suite")
+}
Review Comment:
This package now defines a Ginkgo `RunSpecs` entrypoint in
`checker_test.go`, but `schema_suite_test.go` also defines a `RunSpecs`
entrypoint. Ginkgo only supports a single `RunSpecs` per package; having two
will cause the test suite setup to fail at runtime. Keep exactly one `TestXxx`
that calls `RunSpecs` for `banyand/metadata/schema` (typically in
`*_suite_test.go`), and remove/merge the other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
