This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch feat/segmeta in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
commit b682fd559f99d83020fa9e47d6c56bc49e3d3d74 Author: Hongtao Gao <[email protected]> AuthorDate: Tue Apr 7 01:24:03 2026 +0000 fix(storage): check json.Marshal error returns in test --- banyand/internal/storage/segment_test.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/banyand/internal/storage/segment_test.go b/banyand/internal/storage/segment_test.go index 12d3dbd50..a8a163430 100644 --- a/banyand/internal/storage/segment_test.go +++ b/banyand/internal/storage/segment_test.go @@ -761,14 +761,16 @@ func TestOpenReadsPersistedEndTime(t *testing.T) { segPath1 := filepath.Join(tempDir, "seg-"+day1.Format(dayFormat)) require.NoError(t, os.MkdirAll(segPath1, DirPerm)) meta1 := segmentMeta{Version: currentVersion, EndTime: customEnd.Format(time.RFC3339Nano)} - meta1Data, _ := json.Marshal(meta1) + meta1Data, marshalErr := json.Marshal(meta1) + require.NoError(t, marshalErr) require.NoError(t, os.WriteFile(filepath.Join(segPath1, metadataFilename), meta1Data, FilePerm)) // day2 with standard endTime. segPath2 := filepath.Join(tempDir, "seg-"+day2.Format(dayFormat)) require.NoError(t, os.MkdirAll(segPath2, DirPerm)) meta2 := segmentMeta{Version: currentVersion, EndTime: day2.Add(24 * time.Hour).Format(time.RFC3339Nano)} - meta2Data, _ := json.Marshal(meta2) + meta2Data, marshalErr := json.Marshal(meta2) + require.NoError(t, marshalErr) require.NoError(t, os.WriteFile(filepath.Join(segPath2, metadataFilename), meta2Data, FilePerm)) // Open the controller (loads segments from disk).
