mrproliu commented on code in PR #1046:
URL:
https://github.com/apache/skywalking-banyandb/pull/1046#discussion_r3042728633
##########
banyand/internal/storage/storage.go:
##########
@@ -64,7 +64,9 @@ const (
var (
// ErrUnknownShard indicates that the shard is not found.
ErrUnknownShard = errors.New("unknown shard")
- errOpenDatabase = errors.New("fails to open the database")
+ // ErrNoCurrentSnapshot is returned when a shard has no current
snapshot available.
+ ErrNoCurrentSnapshot = errors.New("no current snapshot available")
Review Comment:
If this variable is unexported, then the `stream/trace/measure` cannot share
the same logical to check the snapshot exist or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
