mrproliu commented on code in PR #240: URL: https://github.com/apache/skywalking-go/pull/240#discussion_r3042457574
########## docs/en/agent/support-plugins.md: ########## @@ -21,11 +21,13 @@ metrics based on the tracing data. * `microv4`: [Go-Micro](https://github.com/go-micro/go-micro) tested v4.6.0 to v4.10.2. * `grpc` : [gRPC](https://github.com/grpc/grpc-go) tested v1.55.0 to v1.64.0. * Database Client - * `gorm`: [GORM](https://github.com/go-gorm/gorm) tested v1.22.0 to v1.25.1. + * `gorm`: [GORM](https://github.com/go-gorm/gorm) tested v1.22.0 to v1.25.10. Review Comment: You have changed the max version of this framework, then please also add the version check in this plugin test. ########## plugins/gorm/go.mod: ########## @@ -3,19 +3,36 @@ module github.com/apache/skywalking-go/plugins/gorm go 1.19 require ( + github.com/apache/skywalking-go/plugins/core v0.0.0-20260210074111-924fc3238ad2 Review Comment: We already using go work in this project, so no needs to import this `plugin/core` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
