wu-sheng commented on code in PR #13772:
URL: https://github.com/apache/skywalking/pull/13772#discussion_r3014159639
##########
oap-server/server-receiver-plugin/otel-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/otel/otlp/OpenTelemetryMetricRequestProcessor.java:
##########
@@ -70,13 +70,17 @@ public class OpenTelemetryMetricRequestProcessor implements
Service {
private final OtelMetricReceiverConfig config;
- private static final Map<String, String> LABEL_MAPPINGS =
+ /**
+ * Fallback label mappings: if the target label (value) is absent in
resource attributes,
+ * copy the source label (key) value as the target. The source label is
always kept as-is
+ * (with dots converted to underscores by the first pass).
+ */
+ private static final Map<String, String> FALLBACK_LABEL_MAPPINGS =
ImmutableMap
.<String, String>builder()
.put("net.host.name", "node_identifier_host_name")
.put("host.name", "node_identifier_host_name")
.put("job", "job_name")
- .put("service.name", "job_name")
.build();
Review Comment:
@pg-yang I did some research, but can't find why to use service name as job
name. This seems an old bug, introduced long time again due to your AWS
firehose PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
