peachisai commented on PR #13745: URL: https://github.com/apache/skywalking/pull/13745#issuecomment-4107498961
> ## Documentation & Config Review (issue #20 follow-up) > The doc (`docs/en/setup/service-agent/virtual-genai.md`) has improved significantly with provider config, cost estimation, and metrics sections. However, a few issues remain: > > ### 1. YAML key mismatch between doc and actual config/code > The doc example uses: > > ```yaml > input-estimated-cost-per-m: 2.5 > output-estimated-cost-per-m: 10 > ``` > > But the actual config file (`gen-ai-config.yml`) and Java class (`GenAIConfig.Model`) use: > > ```yaml > input-cost-per-m: 1 > output-cost-per-m: 1 > ``` > > (Java fields: `inputCostPerM` / `outputCostPerM`) > > The doc example should match the real keys: `input-cost-per-m` / `output-cost-per-m`. > > ### 2. No pricing added to the shipped config > `gen-ai-config.yml` ships with **zero** model pricing entries — every provider only has `prefix-match` rules. The commented-out ollama example shows the `models:` structure, but no real provider (openai, anthropic, etc.) has pricing configured. > > Since cost estimation is a headline feature of this PR, it would be much more useful to ship with well-known model prices pre-configured (at least for major providers like openai, anthropic). Otherwise users get `$0` cost in the dashboard out of the box, which is confusing. > > ### 3. Markdown formatting issue > Line 29-30: `yaml` appears **before** the opening triple backticks instead of after: > > ``` > yaml > ``` > ``` > > Should be: > > ``` > ```yaml > ``` > > ### 4. Typo in Requirement section > `Skwaylking java agent` → `SkyWalking Java Agent` > > ### 5. Ollama prefix-match (per wu-sheng's earlier comment) > Ollama is a runtime, not a model prefix. The `prefix-match: - ollama` entry is still present. Per the earlier discussion it should be blank (require explicit `gen_ai.provider.name` tag). Will update the doc and config -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
