wu-sheng opened a new pull request, #22: URL: https://github.com/apache/skywalking-graalvm-distro/pull/22
### Remove dead wireClosures() code after upstream PR #13750 Upstream [apache/skywalking#13750](https://github.com/apache/skywalking/pull/13750) replaced LambdaMetafactory-based closure wiring with companion classes that self-initialize via `static {}` blocks. Closure fields (`TagFunction`, `ForEachFunction`, etc.) are now `public static final` and initialized by `new CompanionClass()` in the static initializer — no external reflection or `MethodHandles.privateLookupIn()` needed. This PR: - Bumps the `skywalking` submodule to include PR #13750 - Removes `wireClosures()`, `CLOSURE_TYPES`, `ClosureInfo` and related imports from: - `oap-libs-for-graalvm/.../DSL.java` (runtime replacement) - `MALScriptComparisonBase.java` (test base class) - `PrecompiledMALExecutionTest.java` (execution test) - Re-enables `meter_oap_instance_metrics_aggregation` in so11y e2e test (was skipped due to `.tag()` closure NPE in native image) - Updates CLAUDE.md docs to reflect the new companion class pattern No precompiler changes needed — companion classes (`$_tag` etc.) are written to the same output directory by `MALClassGenerator` and automatically picked up by `scanV2Classes()`. - [x] Compile: `make compile` passes - [x] License headers valid: `license-eye header check` - [ ] Tests pass: `make test` (CI) - [ ] E2E so11y test validates `meter_oap_instance_metrics_aggregation` (CI) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
