Copilot commented on code in PR #266:
URL: https://github.com/apache/skywalking-eyes/pull/266#discussion_r2943627525
##########
assets/styles.yaml:
##########
@@ -115,3 +120,8 @@
start: '"""'
middle: ~
end: '"""'
+
+- id: Slash
+ start: '/'
+ middle: '/'
+ end: '/'
Review Comment:
Adding the Slim comment style (single leading `/`) is not enough for license
*checking*: `pkg/license.CommentIndicatorNormalizer` currently strips `#`,
`//`, `/* ... */`, `<!-- ... -->`, etc., but it does not strip single-slash
comment lines. As a result, Slim files that contain a license like `/ Licensed
to the ASF ...` will not match the normalized license text and will fail
`CheckFile` (including the new `testcase.slim` in `include_test/with_license`).
Please extend the comment indicator normalization to treat `^\s*/(?=\s)` (or
similar) as a comment prefix for Slim-style comments.
##########
assets/languages.yaml:
##########
@@ -4973,6 +4975,8 @@ Ruby:
- ".irbrc"
- ".pryrc"
- ".simplecov"
+ - ".ruby-version"
Review Comment:
Including `.ruby-version` in the Ruby `filenames` list will make this tool
treat it as a Ruby source file and attempt to insert a `# ...` license header
when fixing/checking repos that include it. `.ruby-version` is typically
consumed by rbenv/rvm/asdf as a single version string (comments/headers can
break version resolution). Recommend removing `.ruby-version` from the Ruby
language `filenames` mapping (and letting users handle it via ignore patterns
if they really want it checked), or mapping it to a non-commented text language
instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
