ButterBright commented on code in PR #1005:
URL:
https://github.com/apache/skywalking-banyandb/pull/1005#discussion_r2924412533
##########
banyand/metadata/schema/collector.go:
##########
@@ -199,6 +208,72 @@ func (icr *InfoCollectorRegistry)
collectLiaisonInfoLocal(ctx context.Context, c
return nil, nil
}
+// DropGroup drops the group data files on all nodes.
+func (icr *InfoCollectorRegistry) DropGroup(ctx context.Context, catalog
commonv1.Catalog, group string) error {
+ if localErr := icr.dropGroupLocal(ctx, catalog, group); localErr != nil
{
+ return fmt.Errorf("failed to drop group locally: %w", localErr)
+ }
Review Comment:
If the local drop fails, the task will be marked as PHASE_FAILED. There is
no need to broadcast the drop request in this situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
