sunnysabor commented on PR #6997: URL: https://github.com/apache/shenyu/pull/6997#issuecomment-5931725631
I independently verified the new test does not distinguish the fix: on head `57d6169`, I temporarily removed only `transport.setSessionId(newSessionId)` and ran `./mvnw -pl shenyu-plugin/shenyu-plugin-mcp-server -Dtest=ShenyuStreamableHttpServerTransportProviderTest#testInitializeRegistersSessionUnderReturnedSessionId -Djacoco.skip=true -Dmaven.javadoc.skip=true test`; it still passed (1 test, Checkstyle clean). The test checks the provider maps, which were already keyed by the MCP session ID before this PR. Could it exercise cleanup instead: get the stored `McpServerTransport`, call `closeGracefully().block()`, then assert both maps and `ShenyuMcpExchangeHolder` no longer contain the returned ID? That should fail without the setter and pass with it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
