wy471x commented on PR #6945: URL: https://github.com/apache/shenyu/pull/6945#issuecomment-5929225423
Superseded by #6913 (merged 2026-09-30). #6913 rewrote `SubscribeRepository` to store a `Map<Channel, MqttQoS>` per topic and replaced both get-then-put paths with `computeIfAbsent(...).merge(...)`, which atomically fixes the same lost-update race this PR targets. After merging master into this branch the diff here is empty (0 files changed), so there is nothing left to merge. Verified against master `a12aa3e5`: `SubscribeRepository.java:46-47` and `:59-60` already use `computeIfAbsent + merge`, and the read paths (`:94`, `:105`) only read from `getOrDefault(topic, Collections.emptyMap())`. The concurrency regression tests added here (50 concurrent subscribers to a new topic) were not carried over by #6913 — if that coverage is still wanted, it can be re-submitted as a standalone test PR. Closing as superseded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
