renxf0319 commented on PR #7043:
URL: https://github.com/apache/shenyu/pull/7043#issuecomment-5780202004
Hi @Aias00, thanks for the earlier review.
I rebuilt the branch on top of the latest apache:master as a single commit
(61c2656)
to resolve the merge conflict, which unfortunately dismissed your previous
approval.
Sorry for the churn.
The change is functionally the same as before:
- producer.flush() is called once per batch instead of once per record;
- the batch-level flush is wrapped in try/catch so a KafkaException no
longer escapes
consume0() and makes AbstractLogCollector discard the whole drained batch;
- unit tests added for the once-per-batch flush and the flush failure path.
Local verification: ./mvnw -pl
shenyu-plugin/shenyu-plugin-logging/shenyu-plugin-logging-kafka -am test
→ Tests run: 4, Failures: 0, Errors: 0 (checkstyle passed too).
Could a maintainer please approve the pending workflow runs and take another
look? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
