Copilot commented on code in PR #7037:
URL: https://github.com/apache/shenyu/pull/7037#discussion_r4032585186
##########
shenyu-plugin/shenyu-plugin-logging/shenyu-plugin-logging-common/src/main/java/org/apache/shenyu/plugin/logging/common/utils/LogCollectUtils.java:
##########
@@ -32,7 +32,7 @@
public class LogCollectUtils {
private static final Set<String> BINARY_TYPE_LIST =
Sets.newHashSet("image", "multipart", "cbor",
- "octet-stream", "pdf", "javascript", "css", "html");
+ "octet-stream", "pdf", "javascript", "css", "html", "x-protobuf");
Review Comment:
This new binary subtype is not covered by a regression test. Please add a
`LogCollectUtilsTest` case with `Content-Type: application/x-protobuf` and
assert `isNotBinaryType` returns `false`, so a future change cannot cause
protobuf bodies to be logged as text again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
