eye-gu commented on PR #6414: URL: https://github.com/apache/shenyu/pull/6414#issuecomment-5315665584
Thanks for the review. All addressed and pushed except the last nit: 1. **GET/HEAD retry blocker** — Fixed. 2. **Cache cap / Content-Length** — Fixed. 3. **Constructor compatibility** — Fixed. 4. **int overflow** — Fixed: field/param are `long`; both starter call sites compute in `long`, so any value of `shenyu.httpclient.maxInMemorySize` is now safe (previously ≥2048 overflowed to negative and silently disabled retry everywhere). 5. **Warn log nit** — Fixed. 6. **bufferFactory nit** — Not applicable: `ServerHttpRequest` has no `bufferFactory()` API in Spring — the method exists only on the response side (`ReactiveHttpOutputMessage`), so the suggested change doesn't compile. At runtime both factories share the same channel allocator, and the `NettyDataBuffer` cast in `doRequest` depends on it. Left a comment at the call site. All 5 tests in `RequestBodyReplayRetryTest` (incl. the new GET-retry and oversize-body cases) pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
