XiaoFeiASK opened a new pull request, #1166:
URL: https://github.com/apache/incubator-seata-go/pull/1166

   ## What this PR does:
   1. Fixes the gRPC global commit request message type.
   2. Changes GlobalCommitRequestProto from TYPE_GLOBAL_BEGIN to 
TYPE_GLOBAL_COMMIT.
   3. Adds a regression test that verifies Commit() sends a request with 
TYPE_GLOBAL_COMMIT.
   ## Which issue(s) this PR fixes:
   Fixes #1165
   ## Special notes for your reviewer:
   The gRPC transaction manager constructed a GlobalCommitRequestProto, but 
incorrectly identified it as a global-begin request. This could cause the 
transaction coordinator to route or interpret the request incorrectly.
   The regression test intercepts the request passed to SendSyncRequest and 
verifies its nested message type is TYPE_GLOBAL_COMMIT.
   ## Does this PR introduce a user-facing change?:
   ```release-note
   Fix incorrect gRPC global commit request message type.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to