Copilot commented on code in PR #8215:
URL: https://github.com/apache/incubator-seata/pull/8215#discussion_r3922840193
##########
build/pom.xml:
##########
@@ -368,6 +368,28 @@
</properties>
<build>
<plugins>
+ <!-- Release staging must include JDK-gated modules. -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <version>${maven-enforcer-plugin.version}</version>
+ <executions>
+ <execution>
+ <id>enforce-release-java</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <rules>
+ <requireJavaVersion>
+ <version>[21,)</version>
+ <message>Release deployment
requires JDK 21 or later so seata-threadpool-loom and json-common-jackson3 are
included in Maven staging.</message>
Review Comment:
The existing OSSRH publisher activates `release` while configuring JDK 8
(`.github/workflows/publish-ossrh.yml:36-56`), so this new rule makes every
official publish fail before deployment. Update that workflow to JDK 21 in the
same PR (and verify signing/deployment there), otherwise the 2.7.0 release path
is blocked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
