CuriousLinYu commented on PR #8205: URL: https://github.com/apache/incubator-seata/pull/8205#issuecomment-5488683731
Hi @funky-eyes, thanks for the review — both points were addressed in `2e39148`: the post-wakeup `await(1ms)` is gone, so the merge thread now drains immediately after being signalled (first-message drain latency drops from ~1.4-15.3ms to ~0.09-0.21ms, and batching does not regress — avg batch size 50 vs 21.3 on the original under a 4x25 burst). Details are in the reply above and in the PR description. Two process-side items are still blocking the merge: 1. **CI has not run on this PR at all** — there are no check runs on the head commit and the combined status is `pending`. For a first-time contributor the workflow usually needs a maintainer to approve the run. Could you approve it when you get a chance? 2. The review thread above is still open (the code it refers to has since changed). If `2e39148` looks right to you, resolving it would clear the `blocked` merge state. Happy to make any further adjustments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
