paultanay commented on issue #1073: URL: https://github.com/apache/incubator-seata-go/issues/1073#issuecomment-5397809850
HI @VanKhanhAnny are you still working on it? if not I would like to raise a PR for this, fix is ready locally with All 27 tests pass I have Added the two missing dispatch cases in pkg/remoting/loadbalance/loadbalance.go:42-45 for ConsistentHashLoadBalance and LeastActiveLoadBalance. Both implementations already existed but were never routed to. Added pkg/remoting/loadbalance/loadbalance_test.go with 7 new dispatcher-level tests verifying: - Each of the 5 strategies routes to its implementation - Unknown types fall back to random (preserved behavior) - Empty/closed sessions return nil correctly - Concurrent dispatch works across all strategies - LeastActive properly cleans up closed sessions let me know if you want me to raise a PR. Thanks... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
