Copilot commented on code in PR #8067:
URL: https://github.com/apache/incubator-seata/pull/8067#discussion_r3175937599
##########
seata-spring-autoconfigure/seata-spring-autoconfigure-client/src/main/java/org/apache/seata/spring/boot/autoconfigure/properties/SeataJsonProperties.java:
##########
@@ -31,13 +31,30 @@
@ConfigurationProperties(prefix = JSON_PREFIX)
public class SeataJsonProperties {
+ /**
+ * JSON serializer implementation to use for Seata JSON
serialization/deserialization.
+ * Supported values include fastjson, fastjson2, jackson, jackson3, and
gson.
Review Comment:
The Javadoc lists `jackson3` as a supported value, but in this repo
`jackson3` is only available when built/run on JDK 17+ (otherwise
JsonSerializerFactory falls back to `jackson`). Consider documenting the JDK
requirement/fallback here to avoid misleading Spring Boot users on lower JDKs.
##########
script/client/spring/application.properties:
##########
@@ -183,12 +183,12 @@ seata.registry.zk.password=
seata.registry.custom.name=
+#You can choose from the following options: fastjson, fastjson2, jackson,
jackson3, gson
Review Comment:
This comment suggests `jackson3` is always selectable, but `jackson3`
serializer is only available with JDK 17+ builds; otherwise Seata falls back to
`jackson`. Consider adding a short note about the JDK 17+ requirement/fallback
to prevent confusion.
##########
script/client/spring/application.yml:
##########
@@ -200,13 +200,13 @@ seata:
log:
exception-rate: 100
json:
+ # You can choose from the following options: fastjson, fastjson2, jackson,
jackson3, gson
Review Comment:
This comment suggests `jackson3` is always selectable, but `jackson3`
serializer is only available with JDK 17+ builds; otherwise Seata falls back to
`jackson`. Consider adding a short note about the JDK 17+ requirement/fallback
to prevent confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
