funky-eyes commented on code in PR #8023:
URL: https://github.com/apache/incubator-seata/pull/8023#discussion_r3152181361
##########
pom.xml:
##########
@@ -130,6 +131,16 @@
</dependencyManagement>
<profiles>
+ <!-- profile: onlyBuildOnJDK21+ -->
+ <profile>
+ <id>JDK21Plus</id>
+ <activation>
+ <jdk>[21,)</jdk>
+ </activation>
+ <modules>
+ <module>threadpool-loom</module>
Review Comment:
> Compile-time JDK and runtime classpath are different things though — even
if we publish starter jars built on JDK 25, the published
seata-spring-boot-starter pom doesn't declare seata-threadpool-loom (because
all/pom.xml doesn't), so when a user pulls the starter into their JDK 21+ app,
Maven won't fetch the loom artifact and the SPI lookup returns null. End users
running on whatever JDK they want still need the dependency wired in. Or am I
missing something about how the release artifacts are assembled?
Because we need to support JDK 8 users, seata-threadpool-loom is not bundled
into seata-all. Users who require virtual thread support should explicitly add
the seata-threadpool-loom dependency themselves.
The seata-threadpool-loom module will be published to Maven Central when the
project is deployed using JDK 25.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
