WangzJi commented on code in PR #8023:
URL: https://github.com/apache/incubator-seata/pull/8023#discussion_r3151744014
##########
pom.xml:
##########
@@ -130,6 +131,16 @@
</dependencyManagement>
<profiles>
+ <!-- profile: onlyBuildOnJDK21+ -->
+ <profile>
+ <id>JDK21Plus</id>
+ <activation>
+ <jdk>[21,)</jdk>
+ </activation>
+ <modules>
+ <module>threadpool-loom</module>
Review Comment:
loom module is only wired into the reactor build and server/pom.xml here.
all/pom.xml never depends on seata-threadpool-loom, so
seata-spring-boot-starter on JDK 21+ wont see the virtual provider on the
classpath — loadOptional returns null and we silently fall back to platform
threads. Probably want a JDK21+ profile in all/pom.xml mirroring
server/pom.xml:452-464.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
