maple525866 opened a new pull request, #8072:
URL: https://github.com/apache/incubator-seata/pull/8072
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!-- Please make sure you have read and understood the contributing
guidelines -->
- [ ] I have read the
[CONTRIBUTING.md](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md)
guidelines.
- [ ] I have registered the PR
[changes](https://github.com/apache/incubator-seata/tree/2.x/changes).
### Ⅰ. Describe what this PR did
Core Issue:
- `ROW_LOCK_KEY_SPLIT_CHAR = ";"` is a global single-character delimiter
used to concatenate multiple `rowKey` values into a single string. However,
the sub-element `rowKey` itself contains a `resourceId`, and in SQL Server
scenarios, `resourceId` always contains a semicolon (;). This delimiter
conflicts with the content being delimited, causing an irreversible
"concatenation → splitting" process.
Scope of Impact:
- Only affects Redis storage modes (RedisLocker, RedisLuaLocker,
GlobalLockRedisServiceImpl).
- DB storage mode (LockStoreDataBaseDAO) stores tables row-by-row LockDO,
which does not involve semicolon concatenation and is unaffected.
- File storage mode is similarly unaffected.
- Any scenario other than SQL Server where a semicolon might appear in the
`resourceId` will encounter this issue.
My Fix:
In the final step of constructing the `rowKey`, use `replace(";", "^^^")` to
eliminate the character conflict once and for all.
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes
#97. -->
fixes #8033
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
I have verified the correctness of the changes by adding the corresponding
unit tests.
mvn clean test
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
