Sumit6307 commented on PR #7984:
URL: https://github.com/apache/incubator-seata/pull/7984#issuecomment-4283976607
Hi @funky-eyes,
Thank you for the review and the helpful feedback! I have updated the PR to
address all of the comments. Here is a summary of the improvements made:
1. **Optimized Registry Caching**: Implemented a Double-Checked Locking
(DCL) pattern in `AbstractUndoLogManager` to cache the `Registry` instance.
This prevents any performance overhead from repeated
`RegistryFactory.getInstance()` calls in the hot path.
2. **Consistent Counter Semantics**: Aligned the deletion counter
(`seata.undo.log.delete.count`) to represent "Operation Count" strictly. It now
increments exactly by `1` for both single row deletes and batch deletes,
ensuring consistent metrics regardless of the operation type.
3. **Dependency Fixes**: Added `seata-metrics-core` and
`seata-metrics-registry-compact` to the `pom.xml` so the observability metrics
record properly at runtime.
4. **Improved Test Coverage**: Wrote comprehensive unit tests in
`UndoLogMetricsTest.java` to verify the counter alignments, latency timers, and
summary size recordings (including edge cases where 0 rows are affected).
5. **Code Style**: Applied `mvn spotless:apply` to ensure the codebase
strictly matches formatting standards.
Please let me know if there are any further adjustments needed or if this
is ready to be merged!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
