Copilot commented on code in PR #8059: URL: https://github.com/apache/incubator-seata/pull/8059#discussion_r3108642217
########## .github/workflows/publish-ossrh.yml: ########## @@ -16,9 +16,10 @@ # name: "Publish OSSRH" -on: false -# push: -# branches: [ develop, 2.x, snapshot, "*.*.*" ] +on: + push: + branches: [ disable ] + # branches: [ develop, 2.x, snapshot, "*.*.*" ] Review Comment: Using a dummy push branch (`branches: [ disable ]`) makes the workflow effectively unreachable for everyone (including the upstream repo), which may unintentionally prevent legitimate OSSRH publishes. Consider switching the trigger to `workflow_dispatch` (manual run) and/or adding a job-level guard like `if: github.repository == 'apache/incubator-seata'` to avoid running on forks while keeping a valid, usable publish workflow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
