UokyI opened a new pull request, #8050:
URL: https://github.com/apache/incubator-seata/pull/8050
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!-- Please make sure you have read and understood the contributing
guidelines -->
- [x] I have read the
[CONTRIBUTING.md](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md)
guidelines.
- [x ] I have registered the PR
[changes](https://github.com/apache/incubator-seata/tree/2.x/changes).
### Ⅰ. Describe what this PR did
This PR adds support for SQL Server composite primary keys in Seata. The
changes include:
1. **AbstractConnectionProxy.java**: Fixed SQL Server compatibility issue -
SQL Server does not support array of column names for `getGeneratedKeys`, now
uses `Statement.RETURN_GENERATED_KEYS` instead.
2. **SqlGenerateUtils.java**: Added
`buildWhereConditionListByPKsForSqlServer()` method to handle composite primary
keys. SQL Server does not support tuple IN syntax `(col1,col2) IN
((?,?),(?,?))`, so it now uses AND/OR syntax `(col1=? AND col2=?) OR (col1=?
AND col2=?)`.
3. **SqlServerInsertExecutor.java**: Implemented composite primary key
support for SQL Server INSERT operations. Handles both manually assigned
primary keys and auto-increment columns.
4. **Unit Tests**: Added test cases for SQL Server composite primary key
scenarios in `SqlGenerateUtilsTest` and `SqlServerInsertExecutorTest`.
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes
#97. -->
fixes #8041
### Ⅲ. Why don't you add test cases (unit test/integration test)?
Tests are included in this PR.
- `SqlGenerateUtilsTest.testBuildWhereConditionListByPKsForSqlServer()` -
Tests composite PK WHERE clause generation
-
`SqlGenerateUtilsTest.testBuildWhereConditionListByPKsForSqlServerWithSinglePk()`
- Tests single PK WHERE clause generation
-
`SqlServerInsertExecutorTest.testGetPkValues_compositePrimaryKey_withAllPkInInsert()`
- Tests composite PK with manual values
-
`SqlServerInsertExecutorTest.testGetPkValues_compositePrimaryKey_withAutoIncrement()`
- Tests composite PK with auto-increment
-
`SqlServerInsertExecutorTest.testGetPkValues_compositePrimaryKey_nonAutoIncrementThrowsException()`
- Tests exception handling
### Ⅳ. Describe how to verify it
1. Create a SQL Server table with composite primary key
2. Execute INSERT/UPDATE/DELETE operations through Seata AT mode
3. Verify that undo_log is correctly generated with AND/OR syntax for WHERE
conditions
4. Verify that primary key values are correctly retrieved for both manual
and auto-increment scenarios
### Ⅴ. Special notes for reviews
- SQL Server tuple IN syntax limitation is the key difference from other
databases
- The implementation maintains backward compatibility with existing single
primary key scenarios
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
