funky-eyes commented on code in PR #8030:
URL: https://github.com/apache/incubator-seata/pull/8030#discussion_r3019306280
##########
seata-spring-boot-starter/pom.xml:
##########
@@ -36,6 +36,10 @@
</properties>
<dependencies>
+ <dependency>
+ <groupId>com.fasterxml.jackson.datatype</groupId>
+ <artifactId>jackson-datatype-jsr310</artifactId>
Review Comment:
<img width="1338" height="258" alt="image"
src="https://github.com/user-attachments/assets/53602d65-ca53-4090-9274-6008b825c8f7";
/>
<img width="1366" height="702" alt="image"
src="https://github.com/user-attachments/assets/c38801cf-9ab7-4049-90a2-6afa6e0f9dc3";
/>
<img width="1498" height="594" alt="image"
src="https://github.com/user-attachments/assets/1b6302b7-654f-499f-9dcf-4352e573aaff";
/>
Based on my observation, the dependencies on Jackson in `seata-all` are all
marked with the `provided` scope, which indicates that Seata does not intend to
have a strong dependency on this component. However, the default serialization
for both the TCC and AT modes in Seata itself relies on Jackson. Therefore, I
believe the `scope` of the Jackson-related dependencies in `seata-all` should
be directly changed to `compile`. Otherwise, similar issues may arise in the
future.
@slievrly @xingfudeshi PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
