Tsukilc commented on code in PR #7952:
URL: https://github.com/apache/incubator-seata/pull/7952#discussion_r3013241960
##########
discovery/seata-discovery-raft/src/main/java/org/apache/seata/discovery/registry/raft/RaftRegistryServiceImpl.java:
##########
@@ -170,23 +203,20 @@ protected static void startQueryMetadata() {
new LinkedBlockingQueue<>(),
new NamedThreadFactory("refreshMetadata", 1,
true));
REFRESH_METADATA_EXECUTOR.execute(() -> {
- long metadataMaxAgeMs =
CONFIG.getLong(getMetadataMaxAgeMs(), 30000L);
+ long metadataMaxAgeMs =
CONFIG.getLong(getMetadataMaxAgeMs(), DEFAULT_METADATA_MAX_AGE_MS);
Review Comment:
Yes, the original idea is that updates should be triggered by watch events
when changes occur.
As a fallback for stability, we added this mechanism, but the 300s interval
does seem a bit too long.
是的，原本的思路是：
如果有变更操作，应由 watch 正确返回并更新。
但这里为了稳定的兜底，300s 确实有点太长。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
