knyk-dev opened a new pull request, #1091: URL: https://github.com/apache/incubator-seata-go/pull/1091
<!-- Thanks for sending a pull request! --> <!-- Please make sure you have read and understood the contributing guidelines --> - [ ] I have registered the PR [changes](https://github.com/apache/incubator-seata-go/tree/master/changes). **What this PR does**: As discussed in the recent community bi-weekly meeting, the missing implementations in `TCCResourceManager` cause panics when invoked, which is dangerous for the framework's stability. Thanks to @CAICAIIs for raising this issue and providing the excellent Java-side research! - replace `panic("implement me")` in `TCCResourceManager.LockQuery` with an explicit fallback return: `false, nil` - replace `panic("implement me")` in `TCCResourceManager.UnregisterResource` with an explicit unsupported error - add regression tests to verify both fallback paths no longer panic **Which issue(s) this PR fixes**: Fixes #1072 **Special notes for your reviewer**: Seata Java `2.x` does not provide a TCC-specific implementation for these two methods either. `TCCResourceManager` inherits the default fallback behavior from `AbstractResourceManager`: - `lockQuery(...)` returns `false` - `unregisterResource(...)` throws `NotSupportYetException` This PR keeps the change small and makes the current fallback behavior explicit on the Go side, while leaving future TCC lifecycle changes to a separate discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
