funky-eyes commented on code in PR #8020:
URL: https://github.com/apache/incubator-seata/pull/8020#discussion_r2992094176
##########
core/src/main/java/org/apache/seata/core/rpc/netty/NettyClientChannelManager.java:
##########
@@ -58,6 +58,8 @@ class NettyClientChannelManager {
private final ConcurrentMap<String, Channel> channels = new
ConcurrentHashMap<>();
+ private final ConcurrentMap<String, String> serverVersionMap = new
ConcurrentHashMap<>();
Review Comment:
If there is no logic to clean up the map, then in environments like
Kubernetes where the server IP may change, frequent server restarts could cause
the map to grow indefinitely, eventually leading to an OOM (Out of Memory)
error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
