VanKhanhAnny opened a new pull request, #1075: URL: https://github.com/apache/incubator-seata-go/pull/1075
<!-- Thanks for sending a pull request! --> <!-- Please make sure you have read and understood the contributing guidelines --> - [x] I have registered the PR [changes](https://github.com/apache/incubator-seata-go/tree/master/changes). **What this PR does**: Add the missing selector dispatch branches for `ConsistentHashLoadBalance` and `LeastActiveLoadBalance` in `pkg/remoting/loadbalance/loadbalance.go` and add selector-level regression tests **Which issue(s) this PR fixes**: Fixes a selector-dispatch bug where these two already-implemented strategies fall back to random load balancing <!-- *Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. _If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_* --> Fixes #1073 **Special notes for your reviewer**: This PR is intentionally small and focused on selector dispatch only. It does not change the individual load-balancing algorithm implementations **Does this PR introduce a user-facing change?**: Yes. Configuring `ConsistentHashLoadBalance` or `LeastActiveLoadBalance` now routes to the intended implementation instead of falling back to random load balancing <!-- If no, just write "NONE" in the release-note block below. If yes, a release note is required: Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required". --> ```release-note Fix `loadbalance.Select` so `ConsistentHashLoadBalance` and `LeastActiveLoadBalance` dispatch to their existing implementations ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
