Jitmisra opened a new issue, #1062: URL: https://github.com/apache/incubator-seata-go/issues/1062
Currently, Seata-Go supports an expanding list of registries. While `Nacos` and `Etcd3` already have configuration structures in `pkg/discovery/config.go`, the configs for **ZooKeeper**, **Consul** and **Redis** are missing from `RegistryConfig`. Although there are stub files for these registries (`zk.go`, `consul.go`, `redis.go`), the lack of configuration bindings means users can't pass connection details (like `ServerAddr` or `Password`) via `registry.conf` or CLI flags. This issue proposes adding these missing configuration structures so we can fully implement these registry adapters in the future. ### Expected Behavior The `RegistryConfig` struct should parse configurations for all supported registries. <img width="805" height="455" alt="Image" src="https://github.com/user-attachments/assets/a2448c69-e443-47d5-99e3-639c70b18285"; /> ### Proposed Changes 1. **Add new structs:** Create `ZkConfig`, `ConsulConfig` and `RedisConfig` in `pkg/discovery/config.go` with necessary fields (e.g., `ServerAddr`, `Username`, `Password`, `AclToken`). 2. **Update main config:** Add these new structs into the main `RegistryConfig` struct. 3. **Register flags:** Implement `RegisterFlagsWithPrefix` for each new config so properties can be easily injected. ### Why this matters Adding these configuration structures is the first step to making Seata-Go fully compatible with the Java ecosystem's registry support. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
