YvCeung commented on code in PR #7903: URL: https://github.com/apache/incubator-seata/pull/7903#discussion_r2777321689
########## common/src/main/java/org/apache/seata/common/util/SeataHttpWatch.java: ########## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.seata.common.util; + +import com.fasterxml.jackson.databind.ObjectMapper; +import okhttp3.Call; +import okhttp3.OkHttpClient; +import okhttp3.Request; +import okhttp3.ResponseBody; +import okio.BufferedSource; +import org.apache.seata.common.Constants; +import org.apache.seata.common.exception.FrameworkException; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; +import java.util.Iterator; + +/** + * Seata HTTP/2 Watch implementation. + * Consumes server-pushed event stream via an iterator-style API. + * Each line contains a single event in "data: {json}" format, similar to Kubernetes watch API. + * + * @param <T> event data type + */ +public class SeataHttpWatch<T> + implements Iterator<SeataHttpWatch.Response<T>>, Iterable<SeataHttpWatch.Response<T>>, AutoCloseable { Review Comment: Good point. This Watch represents a single-use streaming source (HTTP event stream), so it is intentionally single-pass. I will clarify this in the class-level Javadoc to avoid misuse. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
